Re: [PATCH v3 4/4] real_path: have callers use real_pathdup and strbuf_realpath

2016-12-12 Thread Junio C Hamano
Brandon Williams writes: > On 12/12, Stefan Beller wrote: >> On Mon, Dec 12, 2016 at 3:47 PM, Junio C Hamano wrote: >> > Junio C Hamano writes: >> > >> >> Brandon Williams writes: >> >> >> >>> Migrate callers of real_path() who duplicate the retern value to use >> >>> real_pathdup or strbuf_re

Re: [PATCH v3 4/4] real_path: have callers use real_pathdup and strbuf_realpath

2016-12-12 Thread Brandon Williams
On 12/12, Stefan Beller wrote: > On Mon, Dec 12, 2016 at 3:47 PM, Junio C Hamano wrote: > > Junio C Hamano writes: > > > >> Brandon Williams writes: > >> > >>> Migrate callers of real_path() who duplicate the retern value to use > >>> real_pathdup or strbuf_realpath. > >> > >> Looks good. > > >

Re: [PATCH v3 4/4] real_path: have callers use real_pathdup and strbuf_realpath

2016-12-12 Thread Stefan Beller
On Mon, Dec 12, 2016 at 3:47 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Brandon Williams writes: >> >>> Migrate callers of real_path() who duplicate the retern value to use >>> real_pathdup or strbuf_realpath. >> >> Looks good. > > This has small non-textual conflicts with Stefan's

Re: [PATCH v3 4/4] real_path: have callers use real_pathdup and strbuf_realpath

2016-12-12 Thread Junio C Hamano
Junio C Hamano writes: > Brandon Williams writes: > >> Migrate callers of real_path() who duplicate the retern value to use >> real_pathdup or strbuf_realpath. > > Looks good. This has small non-textual conflicts with Stefan's embed^Wabsorption topic; please holler if you spot my mismerge. Tha

Re: [PATCH v3 4/4] real_path: have callers use real_pathdup and strbuf_realpath

2016-12-12 Thread Junio C Hamano
Brandon Williams writes: > Migrate callers of real_path() who duplicate the retern value to use > real_pathdup or strbuf_realpath. Looks good.

[PATCH v3 4/4] real_path: have callers use real_pathdup and strbuf_realpath

2016-12-12 Thread Brandon Williams
Migrate callers of real_path() who duplicate the retern value to use real_pathdup or strbuf_realpath. Signed-off-by: Brandon Williams --- builtin/init-db.c | 6 +++--- environment.c | 2 +- setup.c | 13 - sha1_file.c | 2 +- submodule.c | 2 +- transpor