Re: [PATCH v3 4/8] dir: hide untracked contents of untracked dirs

2017-05-17 Thread Junio C Hamano
Samuel Lijin writes: >> /* And our single-liner comments look like this */ >> >>> + for (i = 0; i < dir->nr; i++) { >>> + if (!dir->entries[i]) >>> + continue; >>> + >>> + for (j = i + 1; j < dir->nr; j++) { >

Re: [PATCH v3 4/8] dir: hide untracked contents of untracked dirs

2017-05-17 Thread Samuel Lijin
On Wed, May 17, 2017 at 2:47 AM, Junio C Hamano wrote: > Samuel Lijin writes: > >> When we taught read_directory_recursive() to recurse into untracked >> directories in search of ignored files given DIR_SHOW_IGNORED_TOO, that >> had the side effect of teaching it to collect the untracked contents

Re: [PATCH v3 4/8] dir: hide untracked contents of untracked dirs

2017-05-16 Thread Junio C Hamano
Samuel Lijin writes: > When we taught read_directory_recursive() to recurse into untracked > directories in search of ignored files given DIR_SHOW_IGNORED_TOO, that > had the side effect of teaching it to collect the untracked contents of > untracked directories. It doesn't always make sense to r

[PATCH v3 4/8] dir: hide untracked contents of untracked dirs

2017-05-16 Thread Samuel Lijin
When we taught read_directory_recursive() to recurse into untracked directories in search of ignored files given DIR_SHOW_IGNORED_TOO, that had the side effect of teaching it to collect the untracked contents of untracked directories. It doesn't always make sense to return these, though (we do need