[PATCH v3 6/7] completion: get rid of __gitcomp_1

2013-04-10 Thread Felipe Contreras
There's no point in calling a separate function that is only used in one place. Specially considering that there's no need to call compgen, and we traverse the words ourselves both in __gitcompadd, and __gitcomp_1. So lets squash the functions together, and traverse only once. This improves

Re: [PATCH v3 6/7] completion: get rid of __gitcomp_1

2013-04-10 Thread Eric Sunshine
On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras felipe.contre...@gmail.com wrote: There's no point in calling a separate function that is only used in one place. Specially considering that there's no need to call compgen, and s/Specially/Especially/ we traverse the words ourselves both in

Re: [PATCH v3 6/7] completion: get rid of __gitcomp_1

2013-04-10 Thread John Keeping
On Wed, Apr 10, 2013 at 06:13:06AM -0400, Eric Sunshine wrote: On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras felipe.contre...@gmail.com wrote: we traverse the words ourselves both in __gitcompadd, and __gitcomp_1. s/ourselves/ourself/ Huh? we traverse ... ourselves is correct since

Re: [PATCH v3 6/7] completion: get rid of __gitcomp_1

2013-04-10 Thread Eric Sunshine
On Wed, Apr 10, 2013 at 7:35 AM, John Keeping j...@keeping.me.uk wrote: On Wed, Apr 10, 2013 at 06:13:06AM -0400, Eric Sunshine wrote: On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras felipe.contre...@gmail.com wrote: we traverse the words ourselves both in __gitcompadd, and __gitcomp_1.