[PATCH v4] checkout: add --progress option

2015-11-01 Thread Edmundo Carmona Antoranz
Under normal circumstances, and like other git commands, git checkout will write progress info to stderr if attached to a terminal. This option allows progress to be forced even if not using a terminal. Also, progress can be skipped if using option --no-progress. Signed-off-by: Edmundo Carmona

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Jeff King
On Sun, Nov 01, 2015 at 12:52:57PM -0500, Eric Sunshine wrote: > > diff --git a/Documentation/git-checkout.txt b/Documentation/git-checkout.txt > > index e269fb1..93ba35a 100644 > > --- a/Documentation/git-checkout.txt > > +++ b/Documentation/git-checkout.txt > > @@ -107,6 +107,12 @@ OPTIONS > >

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Eric Sunshine
On Sun, Nov 1, 2015 at 12:47 PM, Edmundo Carmona Antoranz wrote: > Under normal circumstances, and like other git commands, > git checkout will write progress info to stderr if > attached to a terminal. This option allows progress > to be forced even if not using a terminal.

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Edmundo Carmona Antoranz
On Sun, Nov 1, 2015 at 11:52 AM, Eric Sunshine wrote: >> + if (opts.quiet) { >> + opts.show_progress = 0; >> + } else { >> + opts.show_progress = isatty(2); >> + } > > Style: drop

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Eric Sunshine
On Sun, Nov 1, 2015 at 2:19 PM, Jeff King wrote: > On Sun, Nov 01, 2015 at 12:52:57PM -0500, Eric Sunshine wrote: >> > +--progress:: >> > + Progress status is reported on the standard error stream >> > + by default when it is attached to a terminal, unless -q >> > +

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Eric Sunshine
On Sun, Nov 1, 2015 at 2:35 PM, Edmundo Carmona Antoranz wrote: > On Sun, Nov 1, 2015 at 1:29 PM, Eric Sunshine wrote: > +--progress:: > + Progress status is reported on the standard error stream > + by default when it is

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Edmundo Carmona Antoranz
On Sun, Nov 1, 2015 at 1:29 PM, Eric Sunshine wrote: >>> > +--progress:: >>> > + Progress status is reported on the standard error stream >>> > + by default when it is attached to a terminal, unless -q >>> > + is specified. This flag forces progress

Re: [PATCH v4] checkout: add --progress option

2015-11-01 Thread Edmundo Carmona Antoranz
On Sun, Nov 1, 2015 at 2:15 PM, Eric Sunshine wrote: > > Progress status is reported on the standard error stream by > default when it is attached to a terminal, unless `--quiet` is > specified. This flag enables progress reporting even if not > attached