Re: [PATCH v4] remote-curl: fix large pushes with GSSAPI

2013-10-31 Thread Jeff King
On Wed, Oct 30, 2013 at 10:40:30PM +, brian m. carlson wrote: If you would split it out, that would be great. Then I'll simply rebase my patch on top of yours and go from there. I just included your patch on top, since it was the residue left over after committing my refactoring. Please

Re: [PATCH v4] remote-curl: fix large pushes with GSSAPI

2013-10-30 Thread Jeff King
On Tue, Oct 29, 2013 at 02:36:37AM +, brian m. carlson wrote: if (large_request) { + long authtype = 0; + Minor nit, but this will produce an unused variable warning if the code in the #if below doesn't get compiled. I don't know how much we care. +#if

Re: [PATCH v4] remote-curl: fix large pushes with GSSAPI

2013-10-30 Thread brian m. carlson
On Wed, Oct 30, 2013 at 04:45:10AM -0400, Jeff King wrote: However, we do reuse the curl handles. And in the case of rpc case, we are only doing one request at a time, so the handle you get is guaranteed to be the last one used. So it works in practice, but it would break if the curl handle

[PATCH v4] remote-curl: fix large pushes with GSSAPI

2013-10-28 Thread brian m. carlson
Due to an interaction between the way libcurl handles GSSAPI authentication over HTTP and the way git uses libcurl, large pushes (those over http.postBuffer bytes) would fail due to an authentication failure requiring a rewind of the curl buffer. Such a rewind was not possible because the data