Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

Thanks a lot for taking care of this! - Lars On 22 Sep 2015, at 21:17, Junio C Hamano wrote: > Yup, this was privately reported and I just squashed a fix in right now ;-) > > Thanks. "cd t && make test-lint" would have caught it. > > On Tue, Sep 22, 2015 at 12:11 PM,

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

Lars Schneider writes: > This works. OK, and thanks; as I don't do perforce, the squash was without any testing. > Do we need the “-e” option? In syntactic sense, no, but our codebase tends to prefer to have one, because it is easier to spot which ones are the

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

Yup, this was privately reported and I just squashed a fix in right now ;-) Thanks. "cd t && make test-lint" would have caught it. On Tue, Sep 22, 2015 at 12:11 PM, Michael Blume wrote: > I'm seeing test failures > > non-executable tests:

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

I'm seeing test failures non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh ls -l shows that all the other tests are executable but t9825 isn't. On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano wrote: > Lars Schneider writes: > >> This

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

Lars Schneider writes: > If it is no extra work for you, you can remove the quotes around > “db”. I can also create a new patch roll including the sed change > and the quote change if it is easier for you. Now you've tested the SQUASH??? for me, I can just squash that

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

On 22 Sep 2015, at 03:10, Junio C Hamano wrote: > Eric Sunshine writes: > >> Yes, it's because $d is a variable reference, even within double >> quotes. > > s/even/especially/ ;-) > > Here is what I queued as SQUASH??? > > diff --git

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

On 22 Sep 2015, at 01:54, Eric Sunshine wrote: > On Mon, Sep 21, 2015 at 7:03 PM, Lars Schneider > wrote: >> On 21 Sep 2015, at 20:09, Junio C Hamano wrote: >>> larsxschnei...@gmail.com writes: +test_expect_success

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

On 21 Sep 2015, at 20:09, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> A P4 repository can get into a state where it contains a file with >> type UTF-16 that does not contain a valid UTF-16 BOM. If

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

On Mon, Sep 21, 2015 at 7:03 PM, Lars Schneider wrote: > On 21 Sep 2015, at 20:09, Junio C Hamano wrote: >> larsxschnei...@gmail.com writes: >>> +test_expect_success 'init depot with UTF-16 encoded file and artificially >>> remove BOM' ' >>> +(

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

Eric Sunshine writes: > Yes, it's because $d is a variable reference, even within double > quotes. s/even/especially/ ;-) Here is what I queued as SQUASH??? diff --git a/t/t9825-git-p4-handle-utf16-without-bom.sh b/t/t9825-git-p4-handle-utf16-without-bom.sh index

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

larsxschnei...@gmail.com writes: > From: Lars Schneider > > A P4 repository can get into a state where it contains a file with > type UTF-16 that does not contain a valid UTF-16 BOM. If git-p4 > attempts to retrieve the file then the process crashes with a >

[PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

From: Lars Schneider A P4 repository can get into a state where it contains a file with type UTF-16 that does not contain a valid UTF-16 BOM. If git-p4 attempts to retrieve the file then the process crashes with a "Translation of file content failed" error. More info