Re: [PATCH v4 1/3] branch: introduce dont_fail parameter for branchname validation

2018-03-16 Thread Kaartic Sivaraam
On Friday 16 March 2018 01:57 AM, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > So... I am not finding dont_fail that was mentioned on the title > anywhere else in the patch. Such lack of attention to detail is > a bit off-putting. > I'm absolutely sorry x-<

Re: [PATCH v4 1/3] branch: introduce dont_fail parameter for branchname validation

2018-03-15 Thread Junio C Hamano
Kaartic Sivaraam writes: > This parameter allows the branchname validation functions to > optionally return a flag specifying the reason for failure, when > requested. This allows the caller to know why it was about to die. > This allows more useful error messages to

[PATCH v4 1/3] branch: introduce dont_fail parameter for branchname validation

2018-03-10 Thread Kaartic Sivaraam
This parameter allows the branchname validation functions to optionally return a flag specifying the reason for failure, when requested. This allows the caller to know why it was about to die. This allows more useful error messages to be given to the user when trying to rename a branch. The flags