Re: [PATCH v4 1/3] t: do not hide Git's exit code in tests

2016-02-16 Thread Lars Schneider
On 15 Feb 2016, at 18:41, Jeff King wrote: > On Mon, Feb 15, 2016 at 11:17:44AM +0100, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider >> >> Git should not be on the left-hand side of a pipe, because it hides the exit >> code, and we want to

Re: [PATCH v4 1/3] t: do not hide Git's exit code in tests

2016-02-15 Thread Jeff King
On Mon, Feb 15, 2016 at 11:17:44AM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > Git should not be on the left-hand side of a pipe, because it hides the exit > code, and we want to make sure git does not fail. I think this is a nice cleanup. >

[PATCH v4 1/3] t: do not hide Git's exit code in tests

2016-02-15 Thread larsxschneider
From: Lars Schneider Git should not be on the left-hand side of a pipe, because it hides the exit code, and we want to make sure git does not fail. There is one more occurrence of this pattern in t9010-svn-fe.sh which is to evolved to change it easily. Helped-by: Jeff