Re: [PATCH v4 15/23] attr: remove index from git_attr_set_direction()

2018-06-09 Thread Elijah Newren
On Wed, Jun 6, 2018 at 10:02 AM, Nguyễn Thái Ngọc Duy wrote: > Since attr checking API now take the index, there's no need to set an > index in advance with this call. Most call sites are straightforward > because they either pass the_index or NULL (which defaults back to > the_index previously).

[PATCH v4 15/23] attr: remove index from git_attr_set_direction()

2018-06-06 Thread Nguyễn Thái Ngọc Duy
Since attr checking API now take the index, there's no need to set an index in advance with this call. Most call sites are straightforward because they either pass the_index or NULL (which defaults back to the_index previously). There's only one suspicious call site in unpack-trees.c where it sets