Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

On Mon, Aug 08, 2016 at 11:28:02AM -0700, Junio C Hamano wrote: > Kirill Smelkov writes: > > > Another question: I'm preparing another version of "pack-objects: Teach > > --use-bitmap-index codepath to respect --local ..." and was going to > > put > > > > ( updated patch is

Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

Kirill Smelkov writes: > Another question: I'm preparing another version of "pack-objects: Teach > --use-bitmap-index codepath to respect --local ..." and was going to > put > > ( updated patch is in the end of this mail ) > > in the top of the message. Is it ok or better

Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

On Mon, Aug 08, 2016 at 11:08:34AM -0700, Junio C Hamano wrote: > Kirill Smelkov writes: > > > Thanks for the info. I did not knew about show-index when I was starting > > to work on this and later it just came out of sight. Please find > > corrected patch below. > > > > 8<

Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

Kirill Smelkov writes: > Thanks for the info. I did not knew about show-index when I was starting > to work on this and later it just came out of sight. Please find > corrected patch below. > > 8< > From: Kirill Smelkov > Date: Fri, 29 Jul 2016

Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

On Mon, Aug 08, 2016 at 09:56:00AM -0400, Jeff King wrote: > On Fri, Jul 29, 2016 at 10:47:46AM +0300, Kirill Smelkov wrote: > > > @@ -2527,7 +2528,7 @@ static int get_object_list_from_bitmap(struct > > rev_info *revs) > > if (prepare_bitmap_walk(revs) < 0) > > return -1; > > >

Re: [PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

On Fri, Jul 29, 2016 at 10:47:46AM +0300, Kirill Smelkov wrote: > @@ -2527,7 +2528,7 @@ static int get_object_list_from_bitmap(struct rev_info > *revs) > if (prepare_bitmap_walk(revs) < 0) > return -1; > > - if (pack_options_allow_reuse() && > + if

[PATCH v4 2/2] pack-objects: Teach it to use reachability bitmap index when generating non-stdout pack too

Starting from 6b8fda2d (pack-objects: use bitmaps when packing objects) if a repository has bitmap index, pack-objects can nicely speedup "Counting objects" graph traversal phase. That however was done only for case when resultant pack is sent to stdout, not written into a file. The reason here