Re: [PATCH v4 2/3] implement fetching of moved submodules

2017-10-19 Thread Stefan Beller
On Wed, Oct 18, 2017 at 5:35 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> but if we already have a submodule with that name (the most likely >>> explanation for its existence is because it started its life there >>> and then later moved), and the

Re: [PATCH v4 2/3] implement fetching of moved submodules

2017-10-18 Thread Junio C Hamano
Stefan Beller writes: >> but if we already have a submodule with that name (the most likely >> explanation for its existence is because it started its life there >> and then later moved), and the submodule is bound to a different >> path, then that is a different submodule.

Re: [PATCH v4 2/3] implement fetching of moved submodules

2017-10-18 Thread Stefan Beller
On Tue, Oct 17, 2017 at 5:03 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> + /* make sure name does not collide with existing >>> one */ >>> + submodule = submodule_from_name(commit_oid, name); >>> +

Re: [PATCH v4 2/3] implement fetching of moved submodules

2017-10-17 Thread Junio C Hamano
Stefan Beller writes: >> + /* make sure name does not collide with existing one >> */ >> + submodule = submodule_from_name(commit_oid, name); >> + if (submodule) { >> +

Re: [PATCH v4 2/3] implement fetching of moved submodules

2017-10-17 Thread Stefan Beller
On Mon, Oct 16, 2017 at 6:58 AM, Heiko Voigt wrote: > We store the changed submodules paths to calculate which submodule needs > fetching. This does not work for moved submodules since their paths do > not stay the same in case of a moved submodules. In case of new > submodules

[PATCH v4 2/3] implement fetching of moved submodules

2017-10-16 Thread Heiko Voigt
We store the changed submodules paths to calculate which submodule needs fetching. This does not work for moved submodules since their paths do not stay the same in case of a moved submodules. In case of new submodules we do not have a path in the current checkout, since they just appeared in this