Re: [PATCH v4 2/3] refs: make rev-parse --quiet actually quiet

2014-09-16 Thread Junio C Hamano
David Aguilar writes: > This patch now has the t1503 test case squashed into it. > It was previously a separate patch, but it makes more sense > for them to go together. Yes. > diff --git a/refs.c b/refs.c > index 2ce5d69..447e339 100644 > --- a/refs.c > +++ b/refs.c > @@ -3108,7 +3108,7 @@ sta

[PATCH v4 2/3] refs: make rev-parse --quiet actually quiet

2014-09-15 Thread David Aguilar
When a reflog is deleted, e.g. when "git stash" clears its stashes, "git rev-parse --verify --quiet" dies: fatal: Log for refs/stash is empty. The reason is that the get_sha1() code path does not allow us to suppress this message. Pass the flags bitfield through get_sha1_with_context() s