Re: [PATCH v4 2/4] diff: have the diff-* builtins configure diff before initializing revisions

2017-05-11 Thread Marc Branchaud
On 2017-05-08 11:22 PM, Jeff King wrote: On Mon, May 08, 2017 at 12:03:37PM -0400, Marc Branchaud wrote: This matches how the diff Porcelain works. It makes the plumbing commands respect diff's configuration options, such as indentHeuristic, because init_revisions() calls diff_setup() which fi

Re: [PATCH v4 2/4] diff: have the diff-* builtins configure diff before initializing revisions

2017-05-08 Thread Jeff King
On Mon, May 08, 2017 at 12:03:37PM -0400, Marc Branchaud wrote: > This matches how the diff Porcelain works. It makes the plumbing commands > respect diff's configuration options, such as indentHeuristic, because > init_revisions() calls diff_setup() which fills in the diff_options struct. I don

[PATCH v4 2/4] diff: have the diff-* builtins configure diff before initializing revisions

2017-05-08 Thread Marc Branchaud
This matches how the diff Porcelain works. It makes the plumbing commands respect diff's configuration options, such as indentHeuristic, because init_revisions() calls diff_setup() which fills in the diff_options struct. Signed-off-by: Marc Branchaud --- builtin/diff-files.c | 2 +- builtin/