Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I get exactly the same thing as you do below when following these > steps. So it seems your patch in > 2122b01f-7627-cd1b-c7df-751c076f9...@web.de is just fine as-is and I > just screwed something up when testing this. > > Sorry about the

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread René Scharfe
Am 29.06.2017 um 00:21 schrieb René Scharfe: $ git am # pasted my email Applying: coccinelle: add a rule to make "expression" code use FREE_AND_NULL() # results in commit message with scissor line, interesting.. "git am --scissors" commits with the correct message. I'll do a "git config

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread Ævar Arnfjörð Bjarmason
On Thu, Jun 29, 2017 at 12:30 AM, René Scharfe wrote: > Am 29.06.2017 um 00:21 schrieb René Scharfe: >> >> Am 28.06.2017 um 23:39 schrieb Ævar Arnfjörð Bjarmason: >>> >>> >>> On Sun, Jun 25 2017, René Scharfe jotted: >>> Am 16.06.2017 um 21:43 schrieb Junio C Hamano: >

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread René Scharfe
Am 29.06.2017 um 00:21 schrieb René Scharfe: Am 28.06.2017 um 23:39 schrieb Ævar Arnfjörð Bjarmason: On Sun, Jun 25 2017, René Scharfe jotted: Am 16.06.2017 um 21:43 schrieb Junio C Hamano: Ævar Arnfjörð Bjarmason writes: A follow-up to the existing "type" rule added

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread Ævar Arnfjörð Bjarmason
On Wed, Jun 28 2017, René Scharfe jotted: > Am 28.06.2017 um 23:39 schrieb Ævar Arnfjörð Bjarmason: >> >> On Sun, Jun 25 2017, René Scharfe jotted: >> >>> Am 16.06.2017 um 21:43 schrieb Junio C Hamano: Ævar Arnfjörð Bjarmason writes: > A follow-up to the

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread René Scharfe
Am 28.06.2017 um 23:39 schrieb Ævar Arnfjörð Bjarmason: > > On Sun, Jun 25 2017, René Scharfe jotted: > >> Am 16.06.2017 um 21:43 schrieb Junio C Hamano: >>> Ævar Arnfjörð Bjarmason writes: >>> A follow-up to the existing "type" rule added in an earlier change. This

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread Ævar Arnfjörð Bjarmason
On Wed, Jun 28 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason writes: > >> Late reply, sorry. What version of coccinelle are you running? I have >> 1.0.4 (from Debian) and can't get this to produce the same results as >> what I have. >> >> On top of next, I did: >> >>

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Late reply, sorry. What version of coccinelle are you running? I have > 1.0.4 (from Debian) and can't get this to produce the same results as > what I have. > > On top of next, I did: > > Revert "*.[ch] refactoring: make use of the

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-28 Thread Ævar Arnfjörð Bjarmason
On Sun, Jun 25 2017, René Scharfe jotted: > Am 16.06.2017 um 21:43 schrieb Junio C Hamano: >> Ævar Arnfjörð Bjarmason writes: >> >>> A follow-up to the existing "type" rule added in an earlier >>> change. This catches some occurrences that are missed by the previous >>> rule.

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-25 Thread René Scharfe
Am 16.06.2017 um 21:43 schrieb Junio C Hamano: > Ævar Arnfjörð Bjarmason writes: > >> A follow-up to the existing "type" rule added in an earlier >> change. This catches some occurrences that are missed by the previous >> rule. >> >> Signed-off-by: Ævar Arnfjörð Bjarmason

Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-16 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > A follow-up to the existing "type" rule added in an earlier > change. This catches some occurrences that are missed by the previous > rule. > > Signed-off-by: Ævar Arnfjörð Bjarmason > --- Hmph, I wonder if the "type" thing

[PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()

2017-06-15 Thread Ævar Arnfjörð Bjarmason
A follow-up to the existing "type" rule added in an earlier change. This catches some occurrences that are missed by the previous rule. Signed-off-by: Ævar Arnfjörð Bjarmason --- contrib/coccinelle/free.cocci | 7 +++ 1 file changed, 7 insertions(+) diff --git