Re: [PATCH v5] commit.c: use skip_prefix() instead of starts_with()

2014-03-21 Thread Michael Haggerty
On 03/04/2014 11:07 PM, Tanay Abhra wrote: In record_author_date() parse_gpg_output(), the callers of starts_with() not just want to know if the string starts with the prefix, but also can benefit from knowing the string that follows the prefix. By using skip_prefix(), we can do both at

Re: [PATCH v5] commit.c: use skip_prefix() instead of starts_with()

2014-03-21 Thread Michael Haggerty
On 03/21/2014 04:48 PM, Michael Haggerty wrote: On 03/04/2014 11:07 PM, Tanay Abhra wrote: [...] +found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1); +if(!found) { Nit: There should be a space between if and the opening parenthesis. Oops, I see I am too

[PATCH v5] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Tanay Abhra
In record_author_date() parse_gpg_output(), the callers of starts_with() not just want to know if the string starts with the prefix, but also can benefit from knowing the string that follows the prefix. By using skip_prefix(), we can do both at the same time. Helped-by: Max Horn m...@quendi.de