Re: [PATCH v5 0/7] Fast git status via a file system watcher

2017-07-10 Thread Ben Peart
On 7/10/2017 9:36 AM, Ben Peart wrote: On 6/28/2017 1:11 AM, Christian Couder wrote: On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart wrote: Changes from V4 include: ... I took a look at this patch series except the last patch ([PATCH v5 7/7] fsmonitor: add a performance

Re: [PATCH v5 0/7] Fast git status via a file system watcher

2017-07-10 Thread Ben Peart
On 6/28/2017 1:11 AM, Christian Couder wrote: On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart wrote: Changes from V4 include: ... I took a look at this patch series except the last patch ([PATCH v5 7/7] fsmonitor: add a performance test) as Junio reviewed it already, and had

Re: [PATCH v5 0/7] Fast git status via a file system watcher

2017-06-27 Thread Christian Couder
On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart wrote: > Changes from V4 include: ... I took a look at this patch series except the last patch ([PATCH v5 7/7] fsmonitor: add a performance test) as Junio reviewed it already, and had only a few comments on patches 3/7 and 4/7. I am

[PATCH v5 0/7] Fast git status via a file system watcher

2017-06-10 Thread Ben Peart
Changes from V4 include: fsmonitor.c: Only flag index dirty if fsmonitor extension is added or removed or if new cache or untracked cache entries are marked dirty dir.c: If an untracked cache entry is flagged as fsmonitor_dirty, fall back to existing logic to stat