Re: [PATCH v5 0/7] Speed up unpack_trees()

2018-08-18 Thread Duy Nguyen
On Sun, Aug 19, 2018 at 12:01 AM Elijah Newren wrote: > > On Sat, Aug 18, 2018 at 7:41 AM Nguyễn Thái Ngọc Duy > wrote: > > > > v5 fixes some minor comments from round 4 and a big mistake in 5/5. > > Junio's scary feeling turns out true. There is a missing invalidation > > in keep_entry() which

Re: [PATCH v5 0/7] Speed up unpack_trees()

2018-08-18 Thread Elijah Newren
On Sat, Aug 18, 2018 at 7:41 AM Nguyễn Thái Ngọc Duy wrote: > > v5 fixes some minor comments from round 4 and a big mistake in 5/5. > Junio's scary feeling turns out true. There is a missing invalidation > in keep_entry() which is not added in 6/7. 7/7 makes sure that similar I'm having trouble

[PATCH v5 0/7] Speed up unpack_trees()

2018-08-18 Thread Nguyễn Thái Ngọc Duy
v5 fixes some minor comments from round 4 and a big mistake in 5/5. Junio's scary feeling turns out true. There is a missing invalidation in keep_entry() which is not added in 6/7. 7/7 makes sure that similar problems will not slip through. I had to rebase this series on top of 'master' because