Re: [PATCH v5 0/8] allow non-trailers and multiple-line trailers

2016-10-21 Thread Stefan Beller
On Fri, Oct 21, 2016 at 4:59 PM, Junio C Hamano wrote: > On Fri, Oct 21, 2016 at 10:54 AM, Jonathan Tan > wrote: >> I've updated patch 5/8 to use strcspn and to pass in the list of >> separators, meaning that we no longer accept '=' in file input

Re: [PATCH v5 0/8] allow non-trailers and multiple-line trailers

2016-10-21 Thread Junio C Hamano
On Fri, Oct 21, 2016 at 10:54 AM, Jonathan Tan wrote: > I've updated patch 5/8 to use strcspn and to pass in the list of > separators, meaning that we no longer accept '=' in file input (and also > updated its commit message accordingly). Thanks for a pleasant read.

[PATCH v5 0/8] allow non-trailers and multiple-line trailers

2016-10-21 Thread Jonathan Tan
I've updated patch 5/8 to use strcspn and to pass in the list of separators, meaning that we no longer accept '=' in file input (and also updated its commit message accordingly). We also discussed inlining find_separator, but after looking at the code, I think that it is more convenient if