Re: [PATCH v5 00/15] config: make git_config_set die on failure

2016-02-17 Thread Patrick Steinhardt
On Tue, Feb 16, 2016 at 12:15:35PM -0500, Eric Sunshine wrote: > On Tue, Feb 16, 2016 at 7:56 AM, Patrick Steinhardt wrote: > > [...] > > Junio pointed out that it might not always be the most sensible > > thing to die when install_branch_config fails. After thinking > > about it I

Re: [PATCH v5 00/15] config: make git_config_set die on failure

2016-02-16 Thread Eric Sunshine
On Tue, Feb 16, 2016 at 7:56 AM, Patrick Steinhardt wrote: > [...] > Junio pointed out that it might not always be the most sensible > thing to die when install_branch_config fails. After thinking > about it I changed the behavior of the function to print an error > and advise

[PATCH v5 00/15] config: make git_config_set die on failure

2016-02-16 Thread Patrick Steinhardt
Fifth version of the config refactorings, version 4 can be found at [1]. Besides fixing up the Signed-off's and a typo in a commit message pointed out by Eric Sunshine the biggest changes relate to install_branch_config. Junio pointed out that it might not always be the most sensible thing to die