Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-20 Thread Brandon Williams
On 04/20, Johannes Schindelin wrote: > Hi Brandon, > > On Thu, 20 Apr 2017, Brandon Williams wrote: > > > On 04/20, Johannes Schindelin wrote: > > > > > > On Wed, 19 Apr 2017, Brandon Williams wrote: > > > > > > > On 04/19, Johannes Sixt wrote: > > > > > Am 19.04.2017 um 07:43 schrieb Johannes

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-20 Thread Johannes Schindelin
Hi Brandon, On Thu, 20 Apr 2017, Brandon Williams wrote: > On 04/20, Johannes Schindelin wrote: > > > > On Wed, 19 Apr 2017, Brandon Williams wrote: > > > > > On 04/19, Johannes Sixt wrote: > > > > Am 19.04.2017 um 07:43 schrieb Johannes Sixt: > > > > >Am 19.04.2017 um 01:17 schrieb Brandon

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-20 Thread Brandon Williams
On 04/20, Johannes Schindelin wrote: > Hi Brandon, > > On Wed, 19 Apr 2017, Brandon Williams wrote: > > > On 04/19, Johannes Sixt wrote: > > > Am 19.04.2017 um 07:43 schrieb Johannes Sixt: > > > >Am 19.04.2017 um 01:17 schrieb Brandon Williams: > > > >>Add a test to 't0061-run-command.sh' to

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-20 Thread Johannes Schindelin
Hi Brandon, On Wed, 19 Apr 2017, Brandon Williams wrote: > On 04/19, Johannes Sixt wrote: > > Am 19.04.2017 um 07:43 schrieb Johannes Sixt: > > >Am 19.04.2017 um 01:17 schrieb Brandon Williams: > > >>Add a test to 't0061-run-command.sh' to ensure that run_command can > > >>continue to execute

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-19 Thread Johannes Sixt
Am 19.04.2017 um 17:56 schrieb Brandon Williams: On 04/19, Johannes Sixt wrote: Am 19.04.2017 um 07:43 schrieb Johannes Sixt: Windows can only run scripts with a shbang line. Out of curiosity how did you have t5550 passing on windows then? Since the first patch in this series fixes a that

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-19 Thread Brandon Williams
On 04/19, Johannes Sixt wrote: > Am 19.04.2017 um 07:43 schrieb Johannes Sixt: > >Am 19.04.2017 um 01:17 schrieb Brandon Williams: > >>Add a test to 't0061-run-command.sh' to ensure that run_command can > >>continue to execute scripts which don't include a '#!' line. > > > >Why is this necessary?

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-19 Thread Johannes Sixt
Am 19.04.2017 um 07:43 schrieb Johannes Sixt: Am 19.04.2017 um 01:17 schrieb Brandon Williams: Add a test to 't0061-run-command.sh' to ensure that run_command can continue to execute scripts which don't include a '#!' line. Why is this necessary? I am pretty certain that our emulation layer

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-18 Thread Johannes Sixt
Am 19.04.2017 um 01:17 schrieb Brandon Williams: Add a test to 't0061-run-command.sh' to ensure that run_command can continue to execute scripts which don't include a '#!' line. Why is this necessary? I am pretty certain that our emulation layer on Windows can only run scripts with a shbang

[PATCH v5 02/11] t0061: run_command executes scripts without a #! line

2017-04-18 Thread Brandon Williams
Add a test to 't0061-run-command.sh' to ensure that run_command can continue to execute scripts which don't include a '#!' line. Signed-off-by: Brandon Williams --- t/t0061-run-command.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/t/t0061-run-command.sh