Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Lars Schneider
> On 07 Dec 2017, at 18:37, Kaartic Sivaraam wrote: > > On Thursday 07 December 2017 10:00 PM, Junio C Hamano wrote: >> + >> +if (print_waiting_for_editor) { >> +/* >> + * A dumb terminal cannot erase the line later

Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Lars Schneider
> On 07 Dec 2017, at 16:43, Junio C Hamano wrote: > > lars.schnei...@autodesk.com writes: > >> +if (print_waiting_for_editor) { >> +fprintf(stderr, >> +_("hint: Waiting for your editor to close the >> file... "));

Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Kaartic Sivaraam
On Thursday 07 December 2017 10:00 PM, Junio C Hamano wrote: + + if (print_waiting_for_editor) { + /* +* A dumb terminal cannot erase the line later on. Add a +* newline to separate the hint from subsequent

Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Lars Schneider
> On 07 Dec 2017, at 17:30, Junio C Hamano wrote: > > Lars Schneider writes: > >>> Can you squash that if you like it? > > I thought you also had to update the log message that you forgot to? > > Here is the replacement I queued tentatively.

Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Junio C Hamano
Lars Schneider writes: >> Can you squash that if you like it? I thought you also had to update the log message that you forgot to? Here is the replacement I queued tentatively. -- >8 -- From: Lars Schneider Date: Thu, 7 Dec 2017 16:16:41

Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Lars Schneider
> On 07 Dec 2017, at 16:48, Lars Schneider wrote: > > >> On 07 Dec 2017, at 16:43, Junio C Hamano wrote: >> >> lars.schnei...@autodesk.com writes: >> ... > > How about this? > > fprintf(stderr, >

Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread Junio C Hamano
lars.schnei...@autodesk.com writes: > + if (print_waiting_for_editor) { > + fprintf(stderr, > + _("hint: Waiting for your editor to close the > file... ")); > + if (is_terminal_dumb()) > +

[PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

2017-12-07 Thread lars . schneider
From: Lars Schneider When a graphical GIT_EDITOR is spawned by a Git command that opens and waits for user input (e.g. "git rebase -i"), then the editor window might be obscured by other windows. The user might be left staring at the original Git terminal window without