Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

Fredrik Medley writes: >>> +#define ALLOW_TIP_SHA1 01 >>> +static int allow_unadvertised_object_request; >> >> It is better to use "unsigned int" for these bit masks, as we are >> not interested in the top-most bit getting special-cased by using a >> signed type. I'll amend this (and the o

Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-22 0:07 GMT+02:00 Junio C Hamano : > Fredrik Medley writes: > >> To allow future extensions, e.g. allowing non-tip sha1, replace the >> boolean allow_tip_sha1_in_want variable with the flag-style >> allow_request_with_bare_object_name variable. >> >> Signed-off-by: Fredrik Medley >> --- >

Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

Fredrik Medley writes: > To allow future extensions, e.g. allowing non-tip sha1, replace the > boolean allow_tip_sha1_in_want variable with the flag-style > allow_request_with_bare_object_name variable. > > Signed-off-by: Fredrik Medley > --- > fetch-pack.c | 9 ++--- > upload-pack.c | 20

[PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

To allow future extensions, e.g. allowing non-tip sha1, replace the boolean allow_tip_sha1_in_want variable with the flag-style allow_request_with_bare_object_name variable. Signed-off-by: Fredrik Medley --- fetch-pack.c | 9 ++--- upload-pack.c | 20 +--- 2 files changed,