Re: [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1

2015-05-22 Thread Junio C Hamano
Fredrik Medley writes: > 2015-05-22 0:15 GMT+02:00 Junio C Hamano : > >> It looks like this new set of tests are well thought out; good job. >> >> I spotted a few minor nits, though. All I'll amend while applying >> so there is no need to resend only to correct them. > > I agree on all your comm

Re: [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1

2015-05-22 Thread Fredrik Medley
2015-05-22 0:15 GMT+02:00 Junio C Hamano : > Fredrik Medley writes: > >> --- a/Documentation/technical/protocol-capabilities.txt >> +++ b/Documentation/technical/protocol-capabilities.txt >> @@ -260,6 +260,13 @@ If the upload-pack server advertises this capability, >> fetch-pack may >> send "wan

Re: [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1

2015-05-21 Thread Junio C Hamano
Fredrik Medley writes: > --- a/Documentation/technical/protocol-capabilities.txt > +++ b/Documentation/technical/protocol-capabilities.txt > @@ -260,6 +260,13 @@ If the upload-pack server advertises this capability, > fetch-pack may > send "want" lines with SHA-1s that exist at the server but a

[PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1

2015-05-21 Thread Fredrik Medley
With uploadpack.allowReachableSHA1InWant configuration option set on the server side, "git fetch" can make a request with a "want" line that names an object that has not been advertised (likely to have been obtained out of band or from a submodule pointer). Only objects reachable from the branch ti