Re: [PATCH v5 3/4] format-patch: introduce --base=auto option

2016-04-23 Thread Ye Xiaolong
On Fri, Apr 22, 2016 at 02:54:16PM -0700, Junio C Hamano wrote: >Xiaolong Ye writes: > >> +if (upstream) { >> +unsigned char sha1[20]; >> +if (get_sha1(upstream, sha1)) >> +die(_("Failed to

Re: [PATCH v5 3/4] format-patch: introduce --base=auto option

2016-04-22 Thread Junio C Hamano
Xiaolong Ye writes: > + if (upstream) { > + unsigned char sha1[20]; > + if (get_sha1(upstream, sha1)) > + die(_("Failed to resolve '%s' as a valid > ref."), upstream); > +

[PATCH v5 3/4] format-patch: introduce --base=auto option

2016-04-21 Thread Xiaolong Ye
Introduce --base=auto to record the base commit info automatically, the base_commit will be the merge base of tip commit of the upstream branch and revision-range specified in cmdline. Helped-by: Junio C Hamano Helped-by: Wu Fengguang Signed-off-by: