Re: [PATCH v5 4/9] status: collect per-file data for --porcelain=v2

2016-08-07 Thread Junio C Hamano
Eric Wong writes: >> > Not a big deal (no need to resend for this one alone), but let's >> > make the above properly formatted, i.e. >> > >> >if (ce_stage(ce)) { >> >... >> >} else { >> >... >> >}

Re: [PATCH v5 4/9] status: collect per-file data for --porcelain=v2

2016-08-07 Thread Eric Wong
Johannes Schindelin wrote: > On Fri, 5 Aug 2016, Junio C Hamano wrote: > > Jeff Hostetler writes: > > > } > > > - else > > > + else { > > > d->index_status = DIFF_STATUS_ADDED; > > > + /* Leave {mode,oid}_head zero for adds. */ > > > +

Re: [PATCH v5 4/9] status: collect per-file data for --porcelain=v2

2016-08-07 Thread Johannes Schindelin
Hi Junio, On Fri, 5 Aug 2016, Junio C Hamano wrote: > Jeff Hostetler writes: > > > if (ce_stage(ce)) { > > d->index_status = DIFF_STATUS_UNMERGED; > > d->stagemask |= (1 << (ce_stage(ce) - 1)); > > + /* > > +

Re: [PATCH v5 4/9] status: collect per-file data for --porcelain=v2

2016-08-06 Thread Junio C Hamano
Jeff Hostetler writes: > if (ce_stage(ce)) { > d->index_status = DIFF_STATUS_UNMERGED; > d->stagemask |= (1 << (ce_stage(ce) - 1)); > + /* > + * Don't bother setting {mode,oid}_{head,index} since >

[PATCH v5 4/9] status: collect per-file data for --porcelain=v2

2016-08-05 Thread Jeff Hostetler
From: Jeff Hostetler Collect extra per-file data for porcelain V2 format. The output of `git status --porcelain` leaves out many details about the current status that clients might like to have. This can force them to be less efficient as they may need to launch secondary commands (and try to m