Re: [PATCH v6 12/13] convert: add filter..process option

2016-09-05 Thread Lars Schneider
> On 30 Aug 2016, at 22:46, Jakub Narębski wrote: > >>> The filter can exit right after the "error-all". If the filter does >>> not exit then Git will kill the filter. I'll add this to the docs. >> >> OK. > > Is it explicit kill, or implicit kill: close pipe and end process?

Re: [PATCH v6 12/13] convert: add filter..process option

2016-08-31 Thread Jakub Narębski
Hi, W dniu 31.08.2016 o 06:57, Torsten Bögershausen pisze: > On Tue, Aug 30, 2016 at 03:23:10PM -0700, Junio C Hamano wrote: >> Lars Schneider writes: >>> On 30 Aug 2016, at 20:59, Junio C Hamano wrote: Torsten, could you please in the future remove

Re: [PATCH v6 12/13] convert: add filter..process option

2016-08-30 Thread Torsten Bögershausen
On Tue, Aug 30, 2016 at 03:23:10PM -0700, Junio C Hamano wrote: > Lars Schneider writes: > > > On 30 Aug 2016, at 20:59, Junio C Hamano wrote: > >> > >>> "abort" could be ambiguous because it could be read as "abort only > >>> this file".

Re: [PATCH v6 12/13] convert: add filter..process option

2016-08-30 Thread Junio C Hamano
Lars Schneider writes: > On 30 Aug 2016, at 20:59, Junio C Hamano wrote: >> >>> "abort" could be ambiguous because it could be read as "abort only >>> this file". "abort-all" would work, though. Would you prefer to see >>> "error" replaced by

Re: [PATCH v6 12/13] convert: add filter..process option

2016-08-30 Thread Junio C Hamano
Lars Schneider writes: >> This part of the document is well-written to help filter-writers. > > Thanks! Don't thank me; thank yourself and reviewers of the previous rounds. > The filter can exit right after the "error-all". If the filter does > not exit then Git will

Re: [PATCH v6 12/13] convert: add filter..process option

2016-08-29 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > +In case the filter cannot or does not want to process the content, > +it is expected to respond with an "error" status. Depending on the > +`filter..required` flag Git will interpret that as error > +but it will not stop or restart the filter process. >

[PATCH v6 12/13] convert: add filter..process option

2016-08-25 Thread larsxschneider
From: Lars Schneider Git's clean/smudge mechanism invokes an external filter process for every single blob that is affected by a filter. If Git filters a lot of blobs then the startup time of the external filter processes can become a significant part of the overall Git