Re: [PATCH v6 17/27] refs: move submodule code out of files-backend.c

2017-03-20 Thread Michael Haggerty
On 03/20/2017 01:09 PM, Duy Nguyen wrote: > On Mon, Mar 20, 2017 at 4:05 AM, Michael Haggerty > wrote: >>> [...] >>> diff --git a/refs/refs-internal.h b/refs/refs-internal.h >>> index f732473e1d..dfa1817929 100644 >>> --- a/refs/refs-internal.h >>> +++ b/refs/refs-internal.h >>> @@ -482,12 +482,1

Re: [PATCH v6 17/27] refs: move submodule code out of files-backend.c

2017-03-20 Thread Duy Nguyen
On Mon, Mar 20, 2017 at 4:05 AM, Michael Haggerty wrote: >> [...] >> diff --git a/refs/refs-internal.h b/refs/refs-internal.h >> index f732473e1d..dfa1817929 100644 >> --- a/refs/refs-internal.h >> +++ b/refs/refs-internal.h >> @@ -482,12 +482,11 @@ struct ref_store; >> /* refs backends */ >> >>

Re: [PATCH v6 17/27] refs: move submodule code out of files-backend.c

2017-03-19 Thread Michael Haggerty
On 03/18/2017 03:03 AM, Nguyễn Thái Ngọc Duy wrote: > files-backend is now initialized with a $GIT_DIR. Converting a submodule > path to where real submodule gitdir is located is done in get_ref_store(). > > This gives a slight performance improvement for submodules since we > don't convert submod

[PATCH v6 17/27] refs: move submodule code out of files-backend.c

2017-03-17 Thread Nguyễn Thái Ngọc Duy
files-backend is now initialized with a $GIT_DIR. Converting a submodule path to where real submodule gitdir is located is done in get_ref_store(). This gives a slight performance improvement for submodules since we don't convert submodule path to gitdir at every backend call like before. We pay t