Re: [PATCH v6 2/4] stash: convert drop and clear to builtin

2018-06-28 Thread Paul-Sebastian Ungureanu
Hi, On 27.06.2018 01:17, Johannes Schindelin wrote: I thought you had introduced `get_oidf()` specifically so you could avoid the `rev-parse` call... `get_oidf(&dummy_oid, "%s@{0}", ref_stash)` should do this, right? We discussed this over the IRC channel, but since not everybody might follow

Re: [PATCH v6 2/4] stash: convert drop and clear to builtin

2018-06-26 Thread Johannes Schindelin
Hi Paul, On Mon, 25 Jun 2018, Paul-Sebastian Ungureanu wrote: > diff --git a/builtin/stash--helper.c b/builtin/stash--helper.c > index 1c4387b10..84a537f39 100644 > --- a/builtin/stash--helper.c > +++ b/builtin/stash--helper.c > @@ -414,6 +451,77 @@ static int apply_stash(int argc, const char **a

[PATCH v6 2/4] stash: convert drop and clear to builtin

2018-06-25 Thread Paul-Sebastian Ungureanu
From: Joel Teichroeb Add the drop and clear commands to the builtin helper. These two are each simple, but are being added together as they are quite related. We have to unfortunately keep the drop and clear functions in the shell script as functions are called with parameters internally that ar