Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-23 Thread Johannes Schindelin
Hi Christian, On Mon, 23 May 2016, Christian Couder wrote: > On Mon, May 23, 2016 at 1:07 PM, Johannes Schindelin > wrote: > > > > On Fri, 20 May 2016, Pranit Bauva wrote: > > > >> Frankly, I have no idea what you mean by libification but I will use > >> error() since efforts for libification ha

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-23 Thread Pranit Bauva
Hey Johannes, On Mon, May 23, 2016 at 4:37 PM, Johannes Schindelin wrote: > Hi Pranit, > > On Fri, 20 May 2016, Pranit Bauva wrote: > >> Frankly, I have no idea what you mean by libification but I will use >> error() since efforts for libification have already started. > > The term "libification"

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-23 Thread Christian Couder
On Mon, May 23, 2016 at 1:07 PM, Johannes Schindelin wrote: > > On Fri, 20 May 2016, Pranit Bauva wrote: > >> Frankly, I have no idea what you mean by libification but I will use >> error() since efforts for libification have already started. > > The term "libification" is frequently used in the G

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-23 Thread Johannes Schindelin
Hi Pranit, On Fri, 20 May 2016, Pranit Bauva wrote: > Frankly, I have no idea what you mean by libification but I will use > error() since efforts for libification have already started. The term "libification" is frequently used in the Git project: it means to convert code that was formerly used

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-20 Thread Pranit Bauva
Hey Johannes, On Mon, May 16, 2016 at 6:46 PM, Johannes Schindelin wrote: > Hi, > > On Mon, 16 May 2016, Eric Sunshine wrote: > >> On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote: >> >> > + fp = fopen(".git/BISECT_TERMS", "w"); >> >> Hardcoding ".git/" is wrong for a variety of reasons

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-20 Thread Pranit Bauva
Hey Eric, On Mon, May 16, 2016 at 12:58 PM, Eric Sunshine wrote: > On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote: >> Reimplement the `write_terms` shell function in C and add a `write-terms` >> subcommand to `git bisect--helper` to call it from git-bisect.sh . Also >> remove the subcommand

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-16 Thread Eric Sunshine
On Mon, May 16, 2016 at 12:45 PM, Johannes Schindelin wrote: > On Mon, 16 May 2016, Eric Sunshine wrote: >> On Mon, May 16, 2016 at 9:16 AM, Johannes Schindelin >> wrote: >> > On Mon, 16 May 2016, Eric Sunshine wrote: >> Agreed. Specific to the "established previously" I wrote above, I was >> ref

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-16 Thread Johannes Schindelin
Hi Eric, On Mon, 16 May 2016, Eric Sunshine wrote: > On Mon, May 16, 2016 at 9:16 AM, Johannes Schindelin > wrote: > > On Mon, 16 May 2016, Eric Sunshine wrote: > >> On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva > >> wrote: > >> > + fp = fopen(".git/BISECT_TERMS", "w"); > >> > >> Hardcod

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-16 Thread Eric Sunshine
On Mon, May 16, 2016 at 9:16 AM, Johannes Schindelin wrote: > On Mon, 16 May 2016, Eric Sunshine wrote: >> On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote: >> > + fp = fopen(".git/BISECT_TERMS", "w"); >> >> Hardcoding ".git/" is wrong for a variety of reasons: It won't be correct >> wit

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-16 Thread Johannes Schindelin
Hi, On Mon, 16 May 2016, Eric Sunshine wrote: > On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote: > > > + fp = fopen(".git/BISECT_TERMS", "w"); > > Hardcoding ".git/" is wrong for a variety of reasons: It won't be correct > with linked worktrees, or when GIT_DIR is pointing elsewhere,

Re: [PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-16 Thread Eric Sunshine
On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote: > Reimplement the `write_terms` shell function in C and add a `write-terms` > subcommand to `git bisect--helper` to call it from git-bisect.sh . Also > remove the subcommand `--check-term-format` as it can now be called from > inside the functio

[PATCH v6 3/3] bisect--helper: `write_terms` shell function in C

2016-05-11 Thread Pranit Bauva
Reimplement the `write_terms` shell function in C and add a `write-terms` subcommand to `git bisect--helper` to call it from git-bisect.sh . Also remove the subcommand `--check-term-format` as it can now be called from inside the function write_terms() C implementation. Using `--write-terms` subco