On Mon, Jun 26, 2017 at 10:56 AM, Junio C Hamano wrote:
> Not about this patch, but viewing this with
>
> git show -w --color-moved=zebra
>
> gives an interesting result. The bulk of the part moved are
> re-indented, and the comment string gets zebra stripes, as if the
> line movement det
Lars Schneider writes:
> Refactoring the filter error handling is useful for the subsequent patch
> 'convert: add "status=delayed" to filter process protocol'.
>
> In addition, replace the parentheses around the empty "if" block with a
> single semicolon to adhere to the Git style guide.
>
> Sign
Not about this patch, but viewing this with
git show -w --color-moved=zebra
gives an interesting result. The bulk of the part moved are
re-indented, and the comment string gets zebra stripes, as if the
line movement detection code does not realize that these came from
the same place.
Refactoring the filter error handling is useful for the subsequent patch
'convert: add "status=delayed" to filter process protocol'.
In addition, replace the parentheses around the empty "if" block with a
single semicolon to adhere to the Git style guide.
Signed-off-by: Lars Schneider
---
conve
4 matches
Mail list logo