On Tue, Aug 21, 2018 at 2:46 PM Junio C Hamano wrote:
>
> Stefan Beller writes:
>
> >> ...
> >> OTOH, if it were up to me I would have just gotten rid of
> >> test_must_be_empty and used an existing function with the right
> >> argument, like `test_cmp /dev/null` - but using some form consistentl
Stefan Beller writes:
>> ...
>> OTOH, if it were up to me I would have just gotten rid of
>> test_must_be_empty and used an existing function with the right
>> argument, like `test_cmp /dev/null` - but using some form consistently
>> is the most important, whatever it is.
>
> /dev/null, eh? It sh
On Mon, Aug 20, 2018 at 8:38 PM Stefan Beller wrote:
>
> On Mon, Aug 20, 2018 at 6:18 AM Matthew DeVore wrote:
> >
> > There were many instances in this file where it seemed like BUG would be
> > better, so I created a new commit before this one to switch them over. The
> > interdiff is below.
>
> At the risk of going on a tangent, I assumed this was because enums
> are really ints, and the "default" is there in case the enum somehow
> got assigned to an int without a corresponding value. Either because
> of a cast from an int that was out-of-range, or new values that were
> obtained from
> > heh. Thanks for switching the style; I should have emphasized that
> > (after reflection) I found them equally good, I am used to one
> > over the other more.
> It seems marginally better to me. I also noticed a clean-up patch
> going by that aggressively switched to test_must_be_empty wherever
On Fri, Aug 17, 2018 at 3:28 PM Stefan Beller wrote:
>
> On Fri, Aug 17, 2018 at 3:20 PM Matthew DeVore wrote:
> >
> > On Fri, Aug 17, 2018 at 2:42 PM Stefan Beller wrote:
> > >
> > > On Wed, Aug 15, 2018 at 4:23 PM Matthew DeVore wrote:
> > > >
> > > > Teach list-objects the "tree:0" filter wh
On Mon, Aug 20, 2018 at 11:38 AM Stefan Beller wrote:
>
> On Mon, Aug 20, 2018 at 6:18 AM Matthew DeVore wrote:
> >
> > There were many instances in this file where it seemed like BUG would be
> > better, so I created a new commit before this one to switch them over. The
> > interdiff is below.
>
On Mon, Aug 20, 2018 at 6:18 AM Matthew DeVore wrote:
>
> There were many instances in this file where it seemed like BUG would be
> better, so I created a new commit before this one to switch them over. The
> interdiff is below.
>
> BTW, why are there so many instances of "die" without "_"? I exp
There were many instances in this file where it seemed like BUG would be
better, so I created a new commit before this one to switch them over. The
interdiff is below.
BTW, why are there so many instances of "die" without "_"? I expect all
errors that may be caused by a user to be localized.
I'm
On Thu, Aug 16, 2018 at 1:54 AM Matthew DeVore wrote:
> diff --git a/list-objects-filter.c b/list-objects-filter.c
> index a0ba78b20..8e3caf5bf 100644
> --- a/list-objects-filter.c
> +++ b/list-objects-filter.c
> @@ -80,6 +80,55 @@ static void *filter_blobs_none__init(
> return d;
> }
>
>
On Fri, Aug 17, 2018 at 3:20 PM Matthew DeVore wrote:
>
> On Fri, Aug 17, 2018 at 2:42 PM Stefan Beller wrote:
> >
> > On Wed, Aug 15, 2018 at 4:23 PM Matthew DeVore wrote:
> > >
> > > Teach list-objects the "tree:0" filter which allows for filtering
> > > out all tree and blob objects (unless o
On Fri, Aug 17, 2018 at 2:42 PM Stefan Beller wrote:
>
> On Wed, Aug 15, 2018 at 4:23 PM Matthew DeVore wrote:
> >
> > Teach list-objects the "tree:0" filter which allows for filtering
> > out all tree and blob objects (unless other objects are explicitly
> > specified by the user). The purpose o
On Wed, Aug 15, 2018 at 4:23 PM Matthew DeVore wrote:
>
> Teach list-objects the "tree:0" filter which allows for filtering
> out all tree and blob objects (unless other objects are explicitly
> specified by the user). The purpose of this patch is to allow smaller
> partial clones.
>
> The name of
Teach list-objects the "tree:0" filter which allows for filtering
out all tree and blob objects (unless other objects are explicitly
specified by the user). The purpose of this patch is to allow smaller
partial clones.
The name of this filter - tree:0 - does not explicitly specify that
it also fil
14 matches
Mail list logo
