Re: [PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom

2017-10-02 Thread Junio C Hamano
Taylor Blau writes: > Thank you for pointing this out. I should have run "make test" on this > patch set (or, as you suggested, `git rebase -x "make test" HEAD~7`) > before sending it out. I appreciate you catching my mistake, and I'll > make sure to run "make test" more

Re: [PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom

2017-10-02 Thread Taylor Blau
On Mon, Oct 02, 2017 at 02:51:00AM -0400, Jeff King wrote: > > diff --git a/ref-filter.c b/ref-filter.c > > index 43ed10a5e..6c26b4733 100644 > > --- a/ref-filter.c > > +++ b/ref-filter.c > > @@ -212,9 +212,10 @@ static void contents_atom_parser(const struct > > ref_format *format, struct used_at

Re: [PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom

2017-10-02 Thread Junio C Hamano
Jeff King writes: >> atom->u.contents.option = C_SUB; >> -else if (!strcmp(arg, "trailers")) >> -atom->u.contents.option = C_TRAILERS; >> -else if (skip_prefix(arg, "lines=", )) { >> +else if (skip_prefix(arg, "trailers", )) { >> +

Re: [PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom

2017-10-02 Thread Jeff King
On Sun, Oct 01, 2017 at 10:25:24PM -0700, Taylor Blau wrote: > The %(contents) atom takes a contents "field" as its argument. Since > "trailers" is one of those fields, extend contents_atom_parser to parse > "trailers"'s arguments when used through "%(contents)", like: > >

[PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom

2017-10-01 Thread Taylor Blau
The %(contents) atom takes a contents "field" as its argument. Since "trailers" is one of those fields, extend contents_atom_parser to parse "trailers"'s arguments when used through "%(contents)", like: %(contents:trailers:unfold,only) A caveat: trailers_atom_parser expects NULL when no