Re: [PATCH v7 04/10] convert: move packet_write_line() into pkt-line as packet_writel()

2017-05-14 Thread Junio C Hamano
Jeff King writes: > This isn't a new problem, but I noticed that this function should > probably get annotated to describe its interface. > > Junio, can you pick up the patch below on top of Ben's series (or I'd be > fine if it were squashed into this patch)? Surely. Thanks for

Re: [PATCH v7 04/10] convert: move packet_write_line() into pkt-line as packet_writel()

2017-05-13 Thread Jeff King
On Fri, May 05, 2017 at 11:27:56AM -0400, Ben Peart wrote: > +int packet_writel(int fd, const char *line, ...); This isn't a new problem, but I noticed that this function should probably get annotated to describe its interface. Junio, can you pick up the patch below on top of Ben's series (or

[PATCH v7 04/10] convert: move packet_write_line() into pkt-line as packet_writel()

2017-05-05 Thread Ben Peart
Add packet_writel() which writes multiple lines in a single call and then calls packet_flush_gently(). Update convert.c to use the new packet_writel() function from pkt-line. Signed-off-by: Ben Peart --- convert.c | 23 ++- pkt-line.c | 19