Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

#!/usr/bin/perl Should we have hard-coded PATH to perl here ? /usr/bin/perl --version This is perl, v5.10.0 built for darwin-thread-multi-2level (with 2 registered patches, see perl -V for more detail) + +my $is_passing = Test::More-builder-is_passing; +exit($is_passing ? 0 : 1); This

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

Torsten Bögershausen tbo...@web.de writes: #!/usr/bin/perl Should we have hard-coded PATH to perl here ? This is what is done in other tests: $ head t*/test.pl -n 1 == t0202/test.pl == #!/usr/bin/perl == t9000/test.pl == #!/usr/bin/perl == t9700/test.pl == #!/usr/bin/perl We actually

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr writes: I'd vote for keeping it simple and not having the copyright notice. Most t/*.sh do not have one. The Git history + mailing-list archives are much better than in-code comments to keep track of who wrote what. Remi: any objection on

[PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

I'd vote for keeping it simple and not having the copyright notice. Most t/*.sh do not have one. The Git history + mailing-list archives are much better than in-code comments to keep track of who wrote what. Remi: any objection on removing it? Sorry for not having resent the patches myself,

[PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

From: Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr parse_address_line had not the same behavior whether the user had Mail::Address or not. Teach parse_address_line to behave like Mail::Address. When the user input is correct, this implementation behaves exactly like Mail::Address except

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

Matthieu Moy matthieu@imag.fr writes: diff --git a/t/t9000-addresses.sh b/t/t9000-addresses.sh new file mode 100755 index 000..7223d03 --- /dev/null +++ b/t/t9000-addresses.sh @@ -0,0 +1,30 @@ +#!/bin/sh +# +# Copyright (c) 2015 That does not look like a valid copyright notice.

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@imag.fr writes: diff --git a/t/t9000-addresses.sh b/t/t9000-addresses.sh new file mode 100755 index 000..7223d03 --- /dev/null +++ b/t/t9000-addresses.sh @@ -0,0 +1,30 @@ +#!/bin/sh +# +# Copyright (c) 2015 That