[PATCH v7 2/4] gitweb: Return 1 on validation success instead of passed input

2013-12-11 Thread Krzesimir Nowak
Users of validate_* passing 0 might get failures on correct name because of coercion of 0 to false in code like: die_error(500, invalid ref) unless (check_ref_format (0)); Also, the validate_foo subs are renamed to is_valid_foo. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com ---

Re: [PATCH v7 2/4] gitweb: Return 1 on validation success instead of passed input

2013-12-11 Thread Jakub Narębski
On Wed, Dec 11, 2013 at 12:54 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Users of validate_* passing 0 might get failures on correct name because of coercion of 0 to false in code like: die_error(500, invalid ref) unless (check_ref_format (0)); Very minor issue: there is no