Re: [PATCH v7 30/33] refs: break out resolve_ref_unsafe_submodule

2016-03-01 Thread David Turner
On Tue, 2016-03-01 at 17:21 +, Ramsay Jones wrote: > > On 01/03/16 00:53, David Turner wrote: > > It will soon be useful for resolve_ref_unsafe to support > > submodules. > > But since it is called from so many places, changing it would have > > been painful. Fortunately, it's just a thin

Re: [PATCH v7 30/33] refs: break out resolve_ref_unsafe_submodule

2016-03-01 Thread Ramsay Jones
On 01/03/16 00:53, David Turner wrote: > It will soon be useful for resolve_ref_unsafe to support submodules. > But since it is called from so many places, changing it would have > been painful. Fortunately, it's just a thin wrapper around (the > former) resolve_ref_1. So now resolve_ref_1

[PATCH v7 30/33] refs: break out resolve_ref_unsafe_submodule

2016-02-29 Thread David Turner
It will soon be useful for resolve_ref_unsafe to support submodules. But since it is called from so many places, changing it would have been painful. Fortunately, it's just a thin wrapper around (the former) resolve_ref_1. So now resolve_ref_1 becomes resolve_ref_unsafe_submodule, and it passes