Re: [PATCH v7 4/7] submodule: allow do_submodule_path to work if given gitdir directly

2016-08-18 Thread Jacob Keller
On Thu, Aug 18, 2016 at 11:46 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> Currently, do_submodule_path relies on read_gitfile, which will die() if >> it can't read from the specified gitfile.

Re: [PATCH v7 4/7] submodule: allow do_submodule_path to work if given gitdir directly

2016-08-18 Thread Junio C Hamano
Jacob Keller writes: > From: Jacob Keller > > Currently, do_submodule_path relies on read_gitfile, which will die() if > it can't read from the specified gitfile. Unfortunately, this means that > do_submodule_path will not work when given the

Re: [PATCH v7 4/7] submodule: allow do_submodule_path to work if given gitdir directly

2016-08-18 Thread Stefan Beller
On Wed, Aug 17, 2016 at 5:51 PM, Jacob Keller wrote: > From: Jacob Keller > > Currently, do_submodule_path relies on read_gitfile, which will die() if > it can't read from the specified gitfile. Unfortunately, this means that > do_submodule_path

[PATCH v7 4/7] submodule: allow do_submodule_path to work if given gitdir directly

2016-08-17 Thread Jacob Keller
From: Jacob Keller Currently, do_submodule_path relies on read_gitfile, which will die() if it can't read from the specified gitfile. Unfortunately, this means that do_submodule_path will not work when given the path to a submodule which is checked out directly, such as a