Re: [PATCH v8 01/44] refs.c: constify the sha arguments for ref_transaction_create|delete|update

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > ref_transaction_create|delete|update has no need to modify the sha1 > arguments passed to it so it should use const unsigned char* instead > of unsigned char*. Obviously good. Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the line "unsubscribe git"

[PATCH v8 01/44] refs.c: constify the sha arguments for ref_transaction_create|delete|update

2014-05-15 Thread Ronnie Sahlberg
ref_transaction_create|delete|update has no need to modify the sha1 arguments passed to it so it should use const unsigned char* instead of unsigned char*. Some functions, such as fast_forward_to(), already have its old/new sha1 arguments as consts. This function will at some point need to use ref