Re: [PATCH v8 06/44] refs.c: add an err argument ro delete_loose_ref

2014-05-15 Thread Ronnie Sahlberg
On Thu, May 15, 2014 at 12:04 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> [Subject: refs.c: add an err argument ro delete_loose_ref] > > s/ro/to/ > s/delete_loose_ref/delete_ref_loose/ > >> --- a/refs.c >> +++ b/refs.c >> @@ -2484,17 +2484,22 @@ static int repack_without_ref(const cha

Re: [PATCH v8 06/44] refs.c: add an err argument ro delete_loose_ref

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > [Subject: refs.c: add an err argument ro delete_loose_ref] s/ro/to/ s/delete_loose_ref/delete_ref_loose/ > --- a/refs.c > +++ b/refs.c > @@ -2484,17 +2484,22 @@ static int repack_without_ref(const char *refname) > return repack_without_refs(&refname, 1, NULL); > }

[PATCH v8 06/44] refs.c: add an err argument ro delete_loose_ref

2014-05-15 Thread Ronnie Sahlberg
Add an err argument to delete_loose_ref so that we can pass a descriptive error string back to the caller. Pass the err argument from transaction commit to this function so that transaction users will have a nice error string if the transaction failed due to delete_loose_ref failing. Signed-off-by