Re: [PATCH v8 1/2] Add xpread()

2014-04-10 Thread Junio C Hamano
Johannes Sixt writes: > Am 10.04.2014 20:54, schrieb Yiannis Marangos: >> +ssize_t xpread(int fd, void *buf, size_t len, off_t offset) >> +{ >> +ssize_t nr; >> +if (len > MAX_IO_SIZE) >> +len = MAX_IO_SIZE; > > Odd indentation here. > > -- Hannes Good eyes, even though this is co

Re: [PATCH v8 1/2] Add xpread()

2014-04-10 Thread Johannes Sixt
Am 10.04.2014 20:54, schrieb Yiannis Marangos: > +ssize_t xpread(int fd, void *buf, size_t len, off_t offset) > +{ > + ssize_t nr; > + if (len > MAX_IO_SIZE) > + len = MAX_IO_SIZE; Odd indentation here. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" i

[PATCH v8 1/2] Add xpread()

2014-04-10 Thread Yiannis Marangos
xpread() pay attention to EAGAIN/EINTR, so it will resume automatically on interrupted call. Signed-off-by: Yiannis Marangos --- This is actually the 2nd version of this commit but before I emailed it as version 7 because it's a dependency of [PATCH v7 2/2]. Is this the correct way to introduce