Re: [PATCH v8 10/11] convert: make apply_filter() adhere to standard Git error handling

2016-09-25 Thread Jakub Narębski
W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > From: Lars Schneider > > apply_filter() returns a boolean that tells the caller if it > "did convert or did not convert". The variable `ret` was used throughout > the function to track errors whereas `1`

[PATCH v8 10/11] convert: make apply_filter() adhere to standard Git error handling

2016-09-20 Thread larsxschneider
From: Lars Schneider apply_filter() returns a boolean that tells the caller if it "did convert or did not convert". The variable `ret` was used throughout the function to track errors whereas `1` denoted success and `0` failure. This is unusual for the Git source where