Re: [PATCH v8 3/3] bisect--helper: `write_terms` shell function in C

2016-05-24 Thread Pranit Bauva
Hey Christian, On Tue, May 24, 2016 at 1:03 PM, Christian Couder wrote: > On Tue, May 24, 2016 at 9:21 AM, Pranit Bauva wrote: >> diff --git a/git-bisect.sh b/git-bisect.sh >> index 7d7965d..cd39bd0 100755 >> --- a/git-bisect.sh >> +++ b/git-bisect.sh >> @@ -210,7 +210,7 @@ bisect_start() { >>

Re: [PATCH v8 3/3] bisect--helper: `write_terms` shell function in C

2016-05-24 Thread Junio C Hamano
Christian Couder writes: >> diff --git a/git-bisect.sh b/git-bisect.sh >> index 7d7965d..cd39bd0 100755 >> --- a/git-bisect.sh >> +++ b/git-bisect.sh >> @@ -210,7 +210,7 @@ bisect_start() { >> eval "$eval true" && >> if test $must_write_terms -eq 1 >> then >> -

Re: [PATCH v8 3/3] bisect--helper: `write_terms` shell function in C

2016-05-24 Thread Christian Couder
On Tue, May 24, 2016 at 9:21 AM, Pranit Bauva wrote: > Reimplement the `write_terms` shell function in C and add a `write-terms` > subcommand to `git bisect--helper` to call it from git-bisect.sh . Also > remove the subcommand `--check-term-format` as it can now be called from > inside the functio

[PATCH v8 3/3] bisect--helper: `write_terms` shell function in C

2016-05-24 Thread Pranit Bauva
Reimplement the `write_terms` shell function in C and add a `write-terms` subcommand to `git bisect--helper` to call it from git-bisect.sh . Also remove the subcommand `--check-term-format` as it can now be called from inside the function write_terms() C implementation. Also `|| exit` is added whe