Re: [PATCH v9 4/5] t6006: add two more tests for the case i18n.commitEncoding is not set

2013-07-05 Thread Junio C Hamano
Alexey Shumkin writes: >> Perhaps we should update test_format so that we can feed a quoted >> input, e.g. >> >> +include an iso8859-1 character: bueno! >> >> or something? > We could use this file whole in UTF-8 but just make a conversion of > expected output as it's done a few lines above

Re: [PATCH v9 4/5] t6006: add two more tests for the case i18n.commitEncoding is not set

2013-07-05 Thread Alexey Shumkin
On Fri, Jul 05, 2013 at 12:04:34AM -0700, Junio C Hamano wrote: > Alexey Shumkin writes: > > > +test_format complex-body %b < > +commit $head3 > > +This commit message is much longer than the others, > > +and it will be encoded in iso8859-1. We should therefore > > +include an iso8859 character:

Re: [PATCH v9 4/5] t6006: add two more tests for the case i18n.commitEncoding is not set

2013-07-05 Thread Junio C Hamano
Alexey Shumkin writes: > +test_format complex-body %b < +commit $head3 > +This commit message is much longer than the others, > +and it will be encoded in iso8859-1. We should therefore > +include an iso8859 character: ¡bueno! This is not such a good idea, as the resulting file will be in mixed

Re: [PATCH v9 4/5] t6006: add two more tests for the case i18n.commitEncoding is not set

2013-07-04 Thread Junio C Hamano
Alexey Shumkin writes: > In de6029a2d7734a93a9e27b9c4471862a47dd8123 'complex-subject' test was > changed. Revert it back,... ... "because changing it was bad for such and such reasons"? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.

[PATCH v9 4/5] t6006: add two more tests for the case i18n.commitEncoding is not set

2013-07-04 Thread Alexey Shumkin
In de6029a2d7734a93a9e27b9c4471862a47dd8123 'complex-subject' test was changed. Revert it back, and add two more tests to test encoding conversions with no i18n.commitEncoding set. Signed-off-by: Alexey Shumkin Reviewed-by: Johannes Sixt --- t/t6006-rev-list-format.sh | 32 +