Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

2016-07-28 Thread Stefan Beller
On Thu, Jul 28, 2016 at 9:22 AM, Junio C Hamano wrote: > Stefan Beller writes: > >>> Anyway, I'll apply the "addition to the completion" patch. >>> >>> Thanks. >> >> Thanks for this patch! >> >> Note: if we ever decide to resurrect

Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

2016-07-28 Thread Junio C Hamano
Stefan Beller writes: >> Anyway, I'll apply the "addition to the completion" patch. >> >> Thanks. > > Thanks for this patch! > > Note: if we ever decide to resurrect sb/submodule-default-path, > we run into a merge conflict. The reasoning for using > "--recurse-submodules"

Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

2016-07-27 Thread Stefan Beller
On Wed, Jul 27, 2016 at 10:32 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> I noticed --recurse-submodules was missing from the bash completion. This >>> adds >>> it. I went for '--recurse-submodules' instead of '--recursive' as I seem to >>>

Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

2016-07-27 Thread Junio C Hamano
Junio C Hamano writes: >> I noticed --recurse-submodules was missing from the bash completion. This >> adds >> it. I went for '--recurse-submodules' instead of '--recursive' as I seem to >> recall the former being agreed upon as the better (or least ambiguous) of the >> two

Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

2016-07-27 Thread Junio C Hamano
Chris Packham writes: > Signed-off-by: Chris Packham > --- > Hi, > > I noticed --recurse-submodules was missing from the bash completion. This adds > it. I went for '--recurse-submodules' instead of '--recursive' as I seem to > recall the former

[PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

2016-07-27 Thread Chris Packham
Signed-off-by: Chris Packham --- Hi, I noticed --recurse-submodules was missing from the bash completion. This adds it. I went for '--recurse-submodules' instead of '--recursive' as I seem to recall the former being agreed upon as the better (or least ambiguous) of the