Re: [PATCHv2] branch -d: test if we can delete broken refs

2014-11-26 Thread Michael Haggerty
Aside from one tiny formatting nit (see below), the test looks good to me. On the other hand, this is kind of an aspirational test; I don't know that the tested functionality has ever worked or that anybody has ever claimed that it works. So my feeling is that the addition of the test would feel

Re: [PATCHv2] branch -d: test if we can delete broken refs

2014-11-26 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: ... On the other hand, this is kind of an aspirational test; I don't know that the tested functionality has ever worked or that anybody has ever claimed that it works. So my feeling is that the addition of the test would feel more natural in the

[PATCHv2] branch -d: test if we can delete broken refs

2014-11-25 Thread Stefan Beller
From: Ronnie Sahlberg sahlb...@google.com Signed-off-by: Ronnie Sahlberg sahlb...@google.com Signed-off-by: Stefan Beller sbel...@google.com --- Changes v1-v2 * relocated the test from t1402 to t3200 * reword the commit message title to fit in with similar commits touching t/t3200-branch.sh