Re: [PATCHv2] commit: reword --author error message

2015-01-27 Thread Ramsay Jones
On 26/01/15 19:07, Jeff King wrote: On Mon, Jan 26, 2015 at 04:48:33PM +0100, Michael J Gruber wrote: -die(_(No existing author found with '%s'), name); +die(_(--author '%s': neither 'Name email' nor a match for an existing author), name); I had to add to the bikeshed, but I had

Re: [PATCHv2] commit: reword --author error message

2015-01-27 Thread Philip Oakley
From: Jeff King p...@peff.net On Mon, Jan 26, 2015 at 06:43:46PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: ... I somehow had trouble making sense of Z (a match...) as a noun. I wonder if adding back in the missing verb, rather than a colon, would also make more

[PATCHv2] commit: reword --author error message

2015-01-26 Thread Michael J Gruber
If an --author argument is specified but does not contain a '' then git tries to find the argument within the existing authors; and gives the error message No existing author found with '%s' if there is no match. This is confusing for users who try to specify a valid complete author name. Rename

Re: [PATCHv2] commit: reword --author error message

2015-01-26 Thread Jeff King
On Mon, Jan 26, 2015 at 04:48:33PM +0100, Michael J Gruber wrote: - die(_(No existing author found with '%s'), name); + die(_(--author '%s': neither 'Name email' nor a match for an existing author), name); I had to add to the bikeshed, but I had to read this several times to make

Re: [PATCHv2] commit: reword --author error message

2015-01-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: ... I somehow had trouble making sense of Z (a match...) as a noun. I wonder if adding back in the missing verb, rather than a colon, would also make more sense: --author '%s' is neither 'Name email' nor a match for an existing author Then --author

Re: [PATCHv2] commit: reword --author error message

2015-01-26 Thread Jeff King
On Mon, Jan 26, 2015 at 06:43:46PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: ... I somehow had trouble making sense of Z (a match...) as a noun. I wonder if adding back in the missing verb, rather than a colon, would also make more sense: --author '%s' is