Re: [PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-20 Thread Stefan Beller
On Fri, May 19, 2017 at 9:50 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> That could be added in ws.c:ws_check_emit, as these certain words >> are similar to coloring whitespace. > > I actually was envisioning of highlighting a part of a line, like > > -Very poor SCM > +Very nic

Re: [PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-19 Thread Junio C Hamano
Stefan Beller writes: > That could be added in ws.c:ws_check_emit, as these certain words > are similar to coloring whitespace. I actually was envisioning of highlighting a part of a line, like -Very poor SCM +Very nice SCM which would be done by finding semi-matching removed and added

Re: [PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-18 Thread Stefan Beller
On Wed, May 17, 2017 at 8:25 PM, Junio C Hamano wrote: > Stefan Beller writes: > +static void show_submodule_header(struct diff_options *o, const char *path, struct object_id *one, struct object_id *two, unsigned dirty_submodule, const char *meta,

Re: [PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-17 Thread Junio C Hamano
Stefan Beller writes: >>> +static void show_submodule_header(struct diff_options *o, const char *path, >>> struct object_id *one, struct object_id *two, >>> unsigned dirty_submodule, const char *meta, >>> const char *reset, >> ... >> How does capturing th

Re: [PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-17 Thread Stefan Beller
On Tue, May 16, 2017 at 10:19 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> In a later patch, I want to propose an option to detect&color >> moved lines in a diff, which cannot be done in a one-pass over >> the diff. Instead we need to go over the whole diff twice, >> because we cannot d

Re: [PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-16 Thread Junio C Hamano
Stefan Beller writes: > In a later patch, I want to propose an option to detect&color > moved lines in a diff, which cannot be done in a one-pass over > the diff. Instead we need to go over the whole diff twice, > because we cannot detect the first line of the two corresponding > lines (+ and -)

[PATCHv2 12/20] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-16 Thread Stefan Beller
In a later patch, I want to propose an option to detect&color moved lines in a diff, which cannot be done in a one-pass over the diff. Instead we need to go over the whole diff twice, because we cannot detect the first line of the two corresponding lines (+ and -) that got moved. So to prepare the