Re: [PATCHv2 27/36] attr: convert to new threadsafe API

2016-10-29 Thread Johannes Sixt
Am 29.10.2016 um 00:06 schrieb Junio C Hamano: Probably this needs to be squashed in, now the MinGW discussion has settled. Yes, this looks good. Thank you very much, both of you. As I said, I won't be able to test this until late next week. -- Hannes attr.c | 2 +- common-main.c

Re: [PATCHv2 27/36] attr: convert to new threadsafe API

2016-10-28 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Oct 28, 2016 at 3:06 PM, Junio C Hamano wrote: >> Probably this needs to be squashed in, now the MinGW discussion has >> settled. > > I was about to propose this (and resend it non-rebased). > > So I do not resend, but

Re: [PATCHv2 27/36] attr: convert to new threadsafe API

2016-10-28 Thread Stefan Beller
On Fri, Oct 28, 2016 at 3:06 PM, Junio C Hamano wrote: > Probably this needs to be squashed in, now the MinGW discussion has > settled. I was about to propose this (and resend it non-rebased). So I do not resend, but rather ask you to squash this patch? Thanks, Stefan

Re: [PATCHv2 27/36] attr: convert to new threadsafe API

2016-10-28 Thread Junio C Hamano
Probably this needs to be squashed in, now the MinGW discussion has settled. attr.c | 2 +- common-main.c | 2 ++ compat/mingw.c | 4 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/attr.c b/attr.c index 082b5ed343..961218a0d5 100644 --- a/attr.c +++ b/attr.c @@

[PATCHv2 27/36] attr: convert to new threadsafe API

2016-10-28 Thread Stefan Beller
This revamps the API of the attr subsystem to be thread safe. Before we had the question and its results in one struct type. The typical usage of the API was static struct git_attr_check *check; if (!check) check = git_attr_check_initl("text", NULL); git_check_attr(path,