Michael J Gruber writes:
>> It should be possible to have a tri-state for the --[no-]textconv
>> option: unset, set to true or set to false. But the code sharing between
>> log, show and diff might make that non-trivial.
>
> Right now it's a diffopt bit...
I wonder if you can do something along
Matthieu Moy venit, vidit, dixit 26.04.2013 15:23:
> Michael J Gruber writes:
>
>> BTW, textconv does not have to be slow - just use textconv-cache.
>
> Right, thanks for reminding me about this, I had forgotten its existance ;-).
>
>> I'm still looking for a way to at least treat "git grep" an
Michael J Gruber writes:
> BTW, textconv does not have to be slow - just use textconv-cache.
Right, thanks for reminding me about this, I had forgotten its existance ;-).
> I'm still looking for a way to at least treat "git grep" and "git show
> blob" the same way.
I agree they should be treat
Junio C Hamano venit, vidit, dixit 24.04.2013 20:55:
> Matthieu Moy writes:
>
>> Grepping through the binary, on the other hand, can very well make
>> sense, like:
>>
>> $ git grep foo
>> file.txt: some instance of foo
>> binary file bar.bin matches
BTW, textconv does not have to be slow - just
Matthieu Moy writes:
> Grepping through the binary, on the other hand, can very well make
> sense, like:
>
> $ git grep foo
> file.txt: some instance of foo
> binary file bar.bin matches
Yes,
I am moderately negative on making it the default, mostly because it
goes against established expectat
Junio C Hamano writes:
> But diff..textconv is to mangle blob contents in preparation
> for comparing with another.
and also in preparation for "blame".
In both cases (diff and blame), we're preparing to show the file content
to the user, and showing the binary makes no sense.
Grepping through
Michael J Gruber writes:
> My point is that we apply textconv on "log diff greps" already, so why
> should't we on content greps?
I think you are going in circles. If you start from "textconv is
about mangling blob contents", then it would look natural to you
that "show ", "diff A B", and "grep
Junio C Hamano venit, vidit, dixit 23.04.2013 17:20:
> Michael J Gruber writes:
>
>> Currently, "git grep" does not honor textconv settings by default.
>> Make it honor them by default just like "git log --grep" does.
>
> "git log --grep" looks for strings in the log message which never
> goes t
Michael J Gruber writes:
> Currently, "git grep" does not honor textconv settings by default.
> Make it honor them by default just like "git log --grep" does.
"git log --grep" looks for strings in the log message which never
goes through textconv filters.
Puzzled
If you meant -S/-G, it jus
Currently, "git grep" does not honor textconv settings by default.
Make it honor them by default just like "git log --grep" does.
Signed-off-by: Michael J Gruber
---
Documentation/git-grep.txt | 2 +-
grep.c | 2 ++
t/t7008-grep-binary.sh | 4 ++--
3 files changed, 5 inse
10 matches
Mail list logo
