Re: [PATCHv3 03/13] xread_nonblock: add functionality to read from fds nonblockingly

2015-09-22 Thread Jacob Keller
On Mon, Sep 21, 2015 at 3:39 PM, Stefan Beller wrote: Maybe change the title to "without blocking" instead of "nonblockingly"? Regards, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCHv3 03/13] xread_nonblock: add functionality to read from fds nonblockingly

2015-09-22 Thread Jacob Keller
On Mon, Sep 21, 2015 at 5:10 PM, Junio C Hamano wrote: >> This wrapper just restarts on EINTR, but not on EAGAIN like xread >> does. This gives less guarantees on the actual reading rather than >> on returning fast. > > The last sentence is a bit hard to parse, by the way. >

Re: [PATCHv3 03/13] xread_nonblock: add functionality to read from fds nonblockingly

2015-09-22 Thread Junio C Hamano
Jacob Keller writes: > On Mon, Sep 21, 2015 at 3:39 PM, Stefan Beller wrote: > > Maybe change the title to "without blocking" instead of "nonblockingly"? Both suggestions make sense ;-) -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCHv3 03/13] xread_nonblock: add functionality to read from fds nonblockingly

2015-09-21 Thread Junio C Hamano
Stefan Beller writes: > This wrapper just restarts on EINTR, but not on EAGAIN like xread > does. This gives less guarantees on the actual reading rather than > on returning fast. > > Signed-off-by: Stefan Beller > --- > git-compat-util.h | 1 + >

[PATCHv3 03/13] xread_nonblock: add functionality to read from fds nonblockingly

2015-09-21 Thread Stefan Beller
This wrapper just restarts on EINTR, but not on EAGAIN like xread does. This gives less guarantees on the actual reading rather than on returning fast. Signed-off-by: Stefan Beller --- git-compat-util.h | 1 + wrapper.c | 22 ++ 2 files changed,

Re: [PATCHv3 03/13] xread_nonblock: add functionality to read from fds nonblockingly

2015-09-21 Thread Junio C Hamano
Stefan Beller writes: > This wrapper just restarts on EINTR, but not on EAGAIN like xread > does. This gives less guarantees on the actual reading rather than > on returning fast. The last sentence is a bit hard to parse, by the way. It lets caller make some progress